Hi Bing, >>> +#include <linux/of.h> >>> #include <net/bluetooth/bluetooth.h> >>> #include <net/bluetooth/hci_core.h> >> >> here now it becomes tricky. Does this now depend on CONFIG_OF as well? > > No. It doesn't depend on CONFIG_OF. > The of.h takes good care of the two OF functions (of_find_node_by_name and of_property_read_u8_array) used in this patch. If CONFIG_OF is not defined, the 1st function returns NULL and the 2nd function returns -ENOSYS. > >> >> What happens to x86 systems that generally do not use open firmware or device tree. Do they still >> work? > > On x86 systems without OF or device tree, the entire calibration data downloading will be skipped. > >> Which kind of devices need the calibration data anyway? All of them? Just the ones without >> EEPROM? > > Some ARM versions of Chromebook need the calibration data. > They do have EEPROM but still need a piece of new calibration data in test mode. > >> >> You need to pretty much verbose in your commit message on what is going on. And I get the feeling >> that you have to handle the case where CONFIG_OF is not selected. > > When CONFIG_OF is not selected, or the specific property is not present in the device tree, the calibration downloading will not happen. > > I can add above messages to the commit log in v2. that would be a good idea. Thanks. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
