Hi Andrei, On Wednesday 30 of October 2013 10:19:15 Andrei Emeltchenko wrote: > Hi Szymon, > > On Tue, Oct 29, 2013 at 04:23:38PM +0100, Szymon Janc wrote: > > Android build system is enabling some additional warnings that are not > > enabled when building with autotools. This avoids spurious warnings > > while building on Android. > > --- > > android/Android.mk | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/android/Android.mk b/android/Android.mk > > index c88b27e..fc1b276 100644 > > --- a/android/Android.mk > > +++ b/android/Android.mk > > @@ -9,6 +9,9 @@ pathmap_INCL += glib:external/bluetooth/glib > > # Specify common compiler flags > > BLUEZ_COMMON_CFLAGS := -DVERSION=\"$(BLUEZ_VERSION)\" > > > > +# Disable warnings enabled by Android but not enabled in autotools build > > +BLUEZ_COMMON_CFLAGS += -Wno-pointer-arith > > I wouldn't put this to BLUEZ_COMMON_CFLAGS, maybe only bluetoothd target > CFLAGS, the issue withing HAL might be easily fixed. We use void pointer > in math operations. This is done on purpose as using void* to operation is simply convenient as there is no need for char* casting (and sizeof(void *) == 1 is documented GCC feature). Further more I think it will be easier for developers if we can have same code guidelines and warnings while building on host and android for all components. -- BR Szymon Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
