Hi Jakub,
On Tue, Oct 29, 2013 at 01:16:55PM +0100, Jakub Tyszkowski wrote:
> This is used to report property change of already reported remote
> device.
>
> ---
> android/hal-bluetooth.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/android/hal-bluetooth.c b/android/hal-bluetooth.c
> index 261ae85..0fef680 100644
> --- a/android/hal-bluetooth.c
> +++ b/android/hal-bluetooth.c
> @@ -114,6 +114,29 @@ static void handle_device_found(void *buf)
> bt_hal_cbacks->device_found_cb(ev->num_props, send_props);
> }
>
> +static void handle_device_state_changed(void *buf)
> +{
> + uint8_t i;
I've got comment myself that first we put variables with assignments.
> + struct hal_ev_remote_device_props *ev = buf;
> + bt_property_t send_props[ev->num_props];
> + struct hal_property *prop = ev->props;
> +
> + if (!bt_hal_cbacks->remote_device_properties_cb)
> + return;
> +
> + /* repack props */
> + for (i = 0; i < ev->num_props; ++i) {
> + send_props[i].type = prop->type;
> + send_props[i].len = prop->len;
> + send_props[i].val = prop->val;
> +
> + prop = (void *) prop + (sizeof(*prop) + prop->len);
> + }
I would put empty line here. This looks a bit more readable then
handle_adapter_props_changed. Do you think those 2 might have reused code?
Best regards
Andrei Emeltchenko
> + bt_hal_cbacks->remote_device_properties_cb(ev->status,
> + (bt_bdaddr_t *)ev->bdaddr,
> + ev->num_props, send_props);
> +}
> +
> /* will be called from notification thread context */
> void bt_notify_adapter(uint16_t opcode, void *buf, uint16_t len)
> {
> @@ -133,6 +156,9 @@ void bt_notify_adapter(uint16_t opcode, void *buf, uint16_t len)
> case HAL_EV_DEVICE_FOUND:
> handle_device_found(buf);
> break;
> + case HAL_EV_REMOTE_DEVICE_PROPS:
> + handle_device_state_changed(buf);
> + break;
> default:
> DBG("Unhandled callback opcode=0x%x", opcode);
> break;
> --
> 1.8.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
