Hi, On Fri, Oct 25, 2013 at 12:36 PM, Andrei Emeltchenko <andrei.emeltchenko.news@xxxxxxxxx> wrote: > Hi Szymon, > > On Fri, Oct 25, 2013 at 10:56:09AM +0200, Szymon Janc wrote: >> This allows HAL to start bonding. >> --- >> android/hal-bluetooth.c | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/android/hal-bluetooth.c b/android/hal-bluetooth.c >> index b81f8dd..6f7ef45 100644 >> --- a/android/hal-bluetooth.c >> +++ b/android/hal-bluetooth.c >> @@ -275,15 +275,17 @@ static int cancel_discovery(void) >> >> static int create_bond(const bt_bdaddr_t *bd_addr) >> { >> + struct hal_cmd_create_bond cmd; >> + >> DBG(""); >> >> if (!interface_ready()) >> return BT_STATUS_NOT_READY; >> >> - if (!bd_addr) >> - return BT_STATUS_PARM_INVALID; > > I think we can leave check here If we are sure it will never be NULL then yes we can remove, otherwise leave it. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html