Re: [PATCH] android: Fix build error for Android

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lukasz,

On Wed, Oct 23, 2013, Lukasz Rymanowski wrote:
> ---
>  android/main.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/android/main.c b/android/main.c
> index 988d08b..606baf2 100644
> --- a/android/main.c
> +++ b/android/main.c
> @@ -52,6 +52,10 @@
>  #include "hal-msg.h"
>  #include "ipc.h"
>  
> +#if defined(ANDROID)
> +#include <sys/capability.h>
> +#endif
> +
>  static GMainLoop *event_loop;
>  static struct mgmt *mgmt_if = NULL;

You're going to have to do a lot more explaining for this one.
Firstly, you should quote the error you get in the commit message.
Secondly, the patch doesn't seem to agree with the subject since the
conditional you're adding shouldn't change anything for the android
build. Thirdly, if there are some quirks with Android (bionic) includes
there should be a proper code comment explaining this so that the piece
of code doesn't by mistake get removed in the future.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux