Re: [PATCH 0/3] Add basic commands to haltest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jerzy,

On Mon, Oct 21, 2013, Jerzy Kasenberg wrote:
> - Adds handling of Ctrl-c Ctrl-d as requested
> - Prompted changed to includ space
> - Added commands: quit exit help
> - Added completion for help
> - Terminal settings restored on exit
> 
> Jerzy Kasenberg (3):
>   android: Add space in prompt in haltest
>   android: Add handling of Ctrl-c to haltest
>   android: Add help and quit to haltest
> 
>  android/client/haltest.c       |  151 ++++++++++++++++++++++++++++++++++------
>  android/client/if-main.h       |    6 ++
>  android/client/tabcompletion.c |  151 ++++++++++++++++++++++++++++------------
>  android/client/terminal.c      |  100 ++++++++++++++++++--------
>  4 files changed, 312 insertions(+), 96 deletions(-)

Patches 1 and 3 have been applied. It seems we had a bit of a
misunderstanding about 2 though. I was looking for ctrl-d (i.e. EOF)
support. Sorry for not being more precise here. Right now when I try
it the following just happens:

jh@x220:bluez{master}$ android/haltest 
> char-0x04

I wouldn't have expected this to be an issue if stdin is processed
properly, but it seems even something like the following doesn't result
in the expected behavior right now (to run all commands in the file and
then exit the tool):

$ tools/haltest < my-script.txt

Another thing I'd like to see fixed is getting the terminal back to a
sane state when exiting. Right now even after a clean exit I seem to
have to do a hard terminal reset to get normal behavior back. As an
example, the following is what I get after cleanly exiting using "exit"
and then pressing enter a couple of times:

jh@x220:bluez{master}$ android/haltest 
> exit
jh@x220:bluez{master}$ jh@x220:bluez{master}$ jh@x220:bluez{master}$ 

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux