Hi Claudio, On Thu, Oct 17, 2013, Claudio Takahasi wrote: > On Wed, Oct 16, 2013 at 5:35 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > > Hi Claudio, > > > > On Wed, Oct 16, 2013, Claudio Takahasi wrote: > >> Bluetooth kernel now restricts LE L2CAP sockets to ATT channels only. > >> For LE L2CAP socket bind, ATT CID is now mandatory. Reference: kernel patch > >> bfe4655f05d7ec4a7c0c1c7e4051862f824cd8ec > >> --- > >> tools/l2test.c | 2 ++ > >> 1 file changed, 2 insertions(+) > > > > Applied thanks. > > > > Btw, I didn't realize that this check wasn't there before. It seems like > > it shouldn't cause any "real life" issues as our btio has always done a > > bind with the correct CID. Can you confirm that this should only be an > > issue for l2test? > > > > Johan > > Yes. btio calls bind with the correct CID. > > I suspect that the is another issue in bt_io_connect() call inside > device_browse_primary(), > the source address type is missing (it is mandatory now). I will send > a patch to fix it. Good catch, though we'll likely need to fix this for the kernel too so that we don't end up with a kernel release that breaks old user space versions. > At some point we need to infer the adapter address type instead of > always use public address. To be honest, selecting whether to use a random address when scanning or advertising doesn't at least immediately strike me as something that should be done through the bind call, but instead something that should be a global setting for the entire adapter. Having the exact LE address type in connect() makes sense, but not necessarily for bind(). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
