Re: [PATCHv5 3/7] android: Use kernel style to initialize struct fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

> ---
> android/hal_bluetooth.c |   46 +++++++++++++++++++++++-----------------------
> 1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/android/hal_bluetooth.c b/android/hal_bluetooth.c
> index 9bb9dcf..89b8ebb 100644
> --- a/android/hal_bluetooth.c
> +++ b/android/hal_bluetooth.c
> @@ -309,29 +309,29 @@ static int dut_mode_send(uint16_t opcode, uint8_t *buf, uint8_t len)
> }
> 
> static const bt_interface_t bluetooth_if = {
> -	sizeof(bt_interface_t),
> -	init,
> -	enable,
> -	disable,
> -	cleanup,
> -	get_adapter_properties,
> -	get_adapter_property,
> -	set_adapter_property,
> -	get_remote_device_properties,
> -	get_remote_device_property,
> -	set_remote_device_property,
> -	get_remote_service_record,
> -	get_remote_services,
> -	start_discovery,
> -	cancel_discovery,
> -	create_bond,
> -	remove_bond,
> -	cancel_bond,
> -	pin_reply,
> -	ssp_reply,
> -	get_profile_interface,
> -	dut_mode_configure,
> -	dut_mode_send
> +	.size = sizeof(bt_interface_t),
> +	.init = init,
> +	.enable = enable,
> +	.disable = disable,
> +	.cleanup = cleanup,
> +	.get_adapter_properties = get_adapter_properties,
> +	.get_adapter_property = get_adapter_property,
> +	.set_adapter_property = set_adapter_property,
> +	.get_remote_device_properties = get_remote_device_properties,
> +	.get_remote_device_property = get_remote_device_property,
> +	.set_remote_device_property = set_remote_device_property,
> +	.get_remote_service_record = get_remote_service_record,
> +	.get_remote_services = get_remote_services,
> +	.start_discovery = start_discovery,
> +	.cancel_discovery = cancel_discovery,
> +	.create_bond = create_bond,
> +	.remove_bond = remove_bond,
> +	.cancel_bond = cancel_bond,
> +	.pin_reply = pin_reply,
> +	.ssp_reply = ssp_reply,
> +	.get_profile_interface = get_profile_interface,
> +	.dut_mode_configure = dut_mode_configure,
> +	.dut_mode_send = dut_mode_send
> };

we could also leave it as is here. Since this does not give any visible improvement for anybody. Also these structure are ABI. So no unintentional reordering will ever happen.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux