Hi Marcel,
On Wed, Oct 16, 2013, Marcel Holtmann wrote:
> static void hci_req_sync_complete(struct hci_dev *hdev, u8 result)
> @@ -734,7 +772,22 @@ static int __hci_init(struct hci_dev *hdev)
> if (err < 0)
> return err;
>
> - return __hci_req_sync(hdev, hci_init4_req, 0, HCI_INIT_TIMEOUT);
> + err = __hci_req_sync(hdev, hci_init4_req, 0, HCI_INIT_TIMEOUT);
> + if (err < 0)
> + return err;
> +
> + /* Only create debugfs entries during the initial setup
> + * phase and not every time the controller gets powered on.
> + */
> + if (!test_bit(HCI_SETUP, &hdev->dev_flags))
> + return 0;
> +
> + if (lmp_bredr_capable(hdev)) {
> + debugfs_create_file("inquiry_cache", 0444, hdev->debugfs,
> + hdev, &inquiry_cache_fops);
> + }
The patch looks good but just a minor nit-pick here: do you really want
to have the curly braces for this one? Even though the function call is
split across two lines it doesn't make it any harder to read without the
braces, for me at least.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
