Re: [PATCH 1/3] Bluetooth: Fix L2CAP "Command Reject: Invalid CID" response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lizardo,

On Wed, Oct 16, 2013, Anderson Lizardo wrote:
> On Wed, Oct 16, 2013 at 4:06 AM,  <johan.hedberg@xxxxxxxxx> wrote:
> > @@ -4217,8 +4225,8 @@ static inline int l2cap_disconnect_req(struct l2cap_conn *conn,
> >
> >         chan = __l2cap_get_chan_by_scid(conn, dcid);
> >         if (!chan) {
> > -               mutex_unlock(&conn->chan_lock);
> > -               return -EBADSLT;
> > +               cmd_reject_invalid_cid(conn, cmd->ident, dcid, scid);
> > +               return 0;
> >         }
> >
> >         l2cap_chan_lock(chan);
> 
> Are you sure this mutex_unlock() call should be removed?

It was indeed a bug which got fixed before this went upstream. Good that
you spotted it too though.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux