On Wed, Oct 16, 2013, Andrei Emeltchenko wrote: > +struct bt_adapter { > + struct mgmt *mgmt; > + bdaddr_t bdaddr; > + uint32_t dev_class; > + > + char *name; > + > + uint32_t supported_settings; > + uint32_t current_settings; > + > + GList *found_devices; > +}; Please don't add variables this way if you don't have code that actually uses them at least later in the patch set. Just add them when they eventually are needed. > +struct bt_device { > + bdaddr_t bdaddr; > + uint8_t bdaddr_type; > + uint32_t cod; > + char *name; > +}; Same thing here. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html