Hi Anderson, >> The variable val in the set_ssp() function of the management interface >> is not needed. Just use cp->val directly since its input values have >> already been validated. >> [...] >> - if (test_bit(HCI_SSP_ENABLED, &hdev->dev_flags) == val) { >> + if (!!cp->val == test_bit(HCI_SSP_ENABLED, &hdev->dev_flags)) { > > In this case, the "!!" trick is unnecessary as the only allowed values > are 0x00 and 0x01 (I believe this has been removed in other similar > cases). it has not been removed. That is why I changed it and made it similar to the other case. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html