Hi Andrei,
>>>>> These types of warnings are disabled in BlueZ makeifiles
>>>>>
>>>>> main.c:67:2: warning: missing initializer [-Wmissing-field-initializers]
>>>>> main.c:67:2: warning: (near initialization for 'options[1].short_name')
>>>>> [-Wmissing-field-initializers]
>>>>> ---
>>>>> android/Android.mk | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/android/Android.mk b/android/Android.mk
>>>>> index ec820ac..5498b41 100644
>>>>> --- a/android/Android.mk
>>>>> +++ b/android/Android.mk
>>>>> @@ -23,6 +23,9 @@ LOCAL_C_INCLUDES := \
>>>>>
>>>>> LOCAL_CFLAGS := -DVERSION=\"$(BLUEZ_VERSION)\"
>>>>>
>>>>> +# to suppress the "warning: missing initializer near initialization.." warning
>>>>> +LOCAL_CFLAGS += -Wno-missing-field-initializers
>>>>> +
>>>>
>>>> why are we doing this and not fixing the actual warning?
>>>>
>>>
>>> Do you want me to initialize structures like
>>>
>>> {NULL, NULL, NULL, ... }
>>>
>>> this way it can be fixed.
>>
>> that is ugly and gets really complicated in the code over time. So I prefer we do not do that.
>>
>> Which structures does this affect. All of them?
>
> You can just try following patch and see:
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index 5bfa29d..4d6a42c 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -15,7 +15,6 @@ AC_DEFUN([COMPILER_FLAGS], [
> if (test "$USE_MAINTAINER_MODE" = "yes"); then
> with_cflags="$with_cflags -Wall -Werror -Wextra"
> with_cflags="$with_cflags -Wno-unused-parameter"
> - with_cflags="$with_cflags -Wno-missing-field-initializers"
> with_cflags="$with_cflags -Wdeclaration-after-statement"
> with_cflags="$with_cflags -Wmissing-declarations"
> with_cflags="$with_cflags -Wredundant-decls"
can we then have a global variable in Android.mk that lists all of our warning exceptions. Re-assigning them over and over again manually seems a rather bad idea.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
