Re: [PATCHv3 03/15] android: Add Socket Bluetooth HAL template

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

>>> +static bt_status_t listen(btsock_type_t type, const char *service_name,
>>> +					const uint8_t *uuid, int chan,
>>> +					int *sock, int flags)
>>> +{
>>> +	if ((uuid == NULL && chan <= 0) || sock == NULL) {
>> 
>> we are moving away from uuid == NULL checks. Use !uuid instead.
> 
> I do not like myself these kind of checks but since this seems to be BlueZ
> style. Should I change comparison val != NULL and val != 0 to !val ? Like
> in kernel?

yes, we are slowly moving towards val and !val checks. Especially for new code that coding style has to be enforced now.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux