Hi Andrei, On Wed, Oct 02, 2013, Andrei Emeltchenko wrote: > On Tue, Oct 01, 2013 at 06:22:02PM +0300, johan.hedberg@xxxxxxxxx wrote: > > From: Johan Hedberg <johan.hedberg@xxxxxxxxx> > > > > This patch introduces a new mgmt command for enabling/disabling BR/EDR > > functionality. This can be convenient when one wants to make a dual-mode > > controller behave like a single-mode one. The command is only available > > for dual-mode controllers and requires that LE is enabled before using > > it. > > ... > > > + > > + if (cp->val != 0x00 && cp->val != 0x01) > > + return cmd_status(sk, hdev->id, MGMT_OP_SET_ADVERTISING, > > + MGMT_STATUS_INVALID_PARAMS); > > + > > + hci_dev_lock(hdev); > > + > > + val = !!cp->val; > > You have already checked that cp->val is 0x0 or 0x1, right? Good point (this was inherited from code that I copied it from). I've removed both val and enabled in my latest set. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
