Re: [PATCH 2/2] android: Android version of log.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fred,

> <snip>
>>> @@ -110,10 +137,22 @@ int main(int argc, char *argv[])
>>> 	sa.sa_handler = signal_handler;
>>> 	sigaction(SIGINT, &sa, NULL);
>>> 	sigaction(SIGTERM, &sa, NULL);
>>> +	sigaction(SIGUSR2, &sa, NULL);
>>> +
>>> +	__btd_log_init(option_debug, option_detach);
>>> +
>>> +	/* no need to keep parsed option in memory */
>>> +	free_options();
>>> +
>>> +	DBG("Entering main loop");
>> 
>> Don't do this debug. It is not helpful. The main() is so short, no point in logging that.
> 
> I need at least one DBG call to be able to build, otherwise I got "undefined reference to `__start___debug'" error messages.
> So, this one seems ok to me.

fair enough for the beginning. Just remove it once you have more than one DBG in the source code and this is no longer needed.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux