Hi Marcel, On Sat, Sep 21, 2013, Marcel Holtmann wrote: > > Define local mapping to glib path, otherwise this has to be inside central > > place in the build repository. > > > > Retrieve Bluetooth version from configure.ac. > > --- > > .gitignore | 2 + > > Android.mk | 9 ++++ > > Makefile.am | 1 + > > Makefile.android | 7 ++++ > > android/Android.mk | 24 +++++++++++ > > android/main.c | 119 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > configure.ac | 5 +++ > > 7 files changed, 167 insertions(+) > > create mode 100644 Android.mk > > create mode 100644 Makefile.android > > create mode 100644 android/Android.mk > > create mode 100644 android/main.c > > lets split this out a little bit. Code additions should not be > intermixed with additions to the build system and especially configure > options. I agree about keeping separate build system changes such as adding completely new makefiles or adding configure options. However, what I think doesn't hurt (and the guidance I've given) is to at least include the matching build system change to the same commit that adds new c/h files. This way you don't end up having "dead code" in the tree in between commits that just lies around there but can't be compiled and wont be included in any release tarballs. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
