Re: [PATCH 4/8] sdp: Decouple Device ID profile implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

> Make DeviceID profile similar to other profiles implementations. Use
> btd_profile for handling DeviceID profile while adding/removing
> adapters. The nice drawback is that SDP code no longer depends on
> main_opts.
> ---
> Makefile.plugins             |   3 +
> profiles/deviceid/deviceid.c | 181 +++++++++++++++++++++++++++++++++++++++++++
> src/sdpd-server.c            |   4 -
> src/sdpd-service.c           |  58 --------------
> src/sdpd.h                   |   2 -
> 5 files changed, 184 insertions(+), 64 deletions(-)
> create mode 100644 profiles/deviceid/deviceid.c
> 
> diff --git a/Makefile.plugins b/Makefile.plugins
> index 7c5f71d..df5d2a1 100644
> --- a/Makefile.plugins
> +++ b/Makefile.plugins
> @@ -82,6 +82,9 @@ builtin_sources += profiles/scanparam/scan.c
> builtin_modules += deviceinfo
> builtin_sources += profiles/deviceinfo/deviceinfo.c
> 
> +builtin_modules += deviceid
> +builtin_sources += profiles/deviceid/deviceid.c
> +

this is changing the semantics a little bit. Device Id record is guaranteed to have 0x10000 handle. I would prefer if we can keep it that way. Also we need to find a way to make this work with the extended inquiry response that can also included device id information.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux