Re: [PATCH 1/1] obexd: Use documented values in org.bluez.obex.Message1 Type property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

On Mon, Sep 9, 2013 at 7:30 PM, Christian Fetzer
<christian.fetzer@xxxxxxxxxxxxxxxx> wrote:
> From: Christian Fetzer <christian.fetzer@xxxxxxxxxxxx>
>
> This updates the values that are presented in the Type property to use
> the values from the documentation ("email", "sms-gsm", "sms-cdma", "mms").
> The existing code directly used the values as received in the messages
> listing object ("EMAIL", "SMS_GSM", "SMS_CDMA", "MMS").
> ---
>  obexd/client/map.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/obexd/client/map.c b/obexd/client/map.c
> index f0dcf72..95f0334 100644
> --- a/obexd/client/map.c
> +++ b/obexd/client/map.c
> @@ -894,7 +894,17 @@ static void parse_type(struct map_msg *msg, const char *value)
>                 return;
>
>         g_free(msg->type);
> -       msg->type = g_strdup(value);
> +
> +       if (strcasecmp(value, "SMS_GSM") == 0)
> +               msg->type = g_strdup("sms-gsm");
> +       else if (strcasecmp(value, "SMS_CDMA") == 0)
> +               msg->type = g_strdup("sms-cdma");
> +       else if (strcasecmp(value, "EMAIL") == 0)
> +               msg->type = g_strdup("email");
> +       else if (strcasecmp(value, "MMS") == 0)
> +               msg->type = g_strdup("mms");
> +       else
> +               msg->type = NULL;
>
>         g_dbus_emit_property_changed(conn, msg->path,
>                                                 MAP_MSG_INTERFACE, "Type");
> --
> 1.8.3.4

Applied, thanks.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux