Re: [PATCH BlueZ 1/3] gobex: Add proper message to transfer errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Aug 8, 2013 at 4:49 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> This improve the error message when a transfer fails by using
> g_obex_strerror to decode the response code to a human readable string.
> ---
>  gobex/gobex-transfer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gobex/gobex-transfer.c b/gobex/gobex-transfer.c
> index ac8836c..4203fec 100644
> --- a/gobex/gobex-transfer.c
> +++ b/gobex/gobex-transfer.c
> @@ -207,8 +207,8 @@ static void transfer_response(GObex *obex, GError *err, GObexPacket *rsp,
>
>         rspcode = g_obex_packet_get_operation(rsp, &final);
>         if (rspcode != G_OBEX_RSP_SUCCESS && rspcode != G_OBEX_RSP_CONTINUE) {
> -               err = g_error_new(G_OBEX_ERROR, rspcode,
> -                                       "Transfer failed (0x%02x)", rspcode);
> +               err = g_error_new(G_OBEX_ERROR, rspcode, "%s",
> +                                               g_obex_strerror(rspcode));
>                 goto failed;
>         }
>
> --
> 1.8.3.1

I went ahead and applied patches 1 and 3, for patch 2 I will wait for
feedback as the filler byte is something Bluetooth specific it can be
controversial.



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux