Hi Dirk, On Mon, Jul 29, 2013, Dirk-Jan C. Binnema wrote: > To paraphrase Anderson Lizardo: "h" was overflowing for 128-bit services > because the handle is incremented after each attribute is added so at the > end we had: 0xffff + 1 == 0 (h is uint16_t). > > As it seems more complex to try to remove the overflow without > affecting the logic too much, we update the assertion. > --- > attrib/gatt-service.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I made a couple of more cosmetic cleanups and after that pushed these patches upstream. Thanks. Some things to keep in mind for future patches: - Keep your commit message line lengths max 72-74 (both git log and git shortlog indent them and we don't want to run past a 80 char terminal) - Prefix the summary lines appropriately (in this case "attrib: ...") - Split lines are indented as much as possible while keeping them under 80 characters (i.e. not just past the opening parenthesis) Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
