Hi Bing, >>> A text file containing calibration data in hex format can >>> be provided while loading btmrvl module. The data will be >>> downloaded to firmware. >>> eg. insmod btmrvl.ko cal_data_cfg=mrvl/bt_cal_data.conf >> >> why is this a module parameter and you do not just request a standard location via request_firmware(). > > Not all devices need downloading the calibration data from host to firmware. > A module parameter seems more flexible than others. it is also way harder to use and things need to be manually configured. Don't know know when the device needs calibration information or not. And you can just request_firmware() that file. If it is there, then load it, if not then skip the step. > The firmware_request() requires a relative file path under /lib/firmware/. > What is the standard location you are referring to? You have to create proper filenames for your hardware. Like mrvl/cal_data_v1.conf or similar. > >> I do not like the module parameter approach. > > I'm open to any other approaches. Do you have any suggestions? As I said above, the device should know if it needs calibration or not. And just installing a file on disk is simpler than having to modify the module parameters somewhere. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
