On Fri, Jul 26, 2013 at 08:07:30AM -0400, Peter Hurley wrote: > On 07/25/2013 02:32 PM, Gianluca Anzolin wrote: > > > > rfcomm_dlc_lock(dlc); > > tty->driver_data = dev; > >- dev->port.tty = tty; > >+ tty_port_tty_set(&dev->port, tty); > > Although strictly speaking, this is correct, I would drop this change > because its functionality is replaced in 4/6 with the call to tty_port_open(). > If you want, you could note in the commit message that the > raw assignments in rfcomm_tty_open/close are addressed in commit > 'rfcomm: Implement .activate, .shutdown and .carrier_raised methods'. Ok I will do that. > > [ BTW, you remove this line in 3/6 but it's needed until 4/6] Oh, I overlooked that "detail" when I changed the order of the patches... > > > rfcomm_dlc_unlock(dlc); > > set_bit(RFCOMM_TTY_ATTACHED, &dev->flags); > > > >@@ -742,7 +747,7 @@ static void rfcomm_tty_close(struct tty_struct *tty, struct file *filp) > > > > rfcomm_dlc_lock(dev->dlc); > > tty->driver_data = NULL; > >- dev->port.tty = NULL; > >+ tty_port_tty_set(&dev->port, NULL); > > Similarly, the call to tty_port_close() in 4/6 replaces this functionality. > > Regards, > Peter Hurley > Ok there is a need for a v4 after all. Btw did you look at the RFC patch about the dev_add nested locks? Do you think it's acceptable? I tried to add the device to the list at the end of the function but the fact is that the dlc callbacks need dev->id so I had to allocate it or set it to something not valid, like -1. I didn't also get any reply about the skb_queue_purge patch, I hope it's ok Thank you, Gianluca -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
