On 07/25/2013 01:37 AM, Gianluca Anzolin wrote:
On Wed, Jul 24, 2013 at 06:28:26PM -0400, Peter Hurley wrote:
Gianluca,
The code you intend to keep in rfcomm_tty_open() should not be moved to
rfcomm_tty_install() in this patch and then moved back to rfcomm_tty_open()
in 4/7. It should stay in rfcomm_tty_open().
Likewise, the code being deleted in rfcomm_tty_install() in 4/7 should
remain in rfcomm_tty_open() here, and be deleted from rfcomm_tty_open() in
4/7 instead.
IOW, there's a much smaller changeset that will achieve the same end
product.
Hello,
sorry I'm not very used to submit patches "the right way" and I missed the
point that I have to keep the changes to the minimum.
No need to apologize.
Every kernel contributor goes through this learning curve.
I also resent the tty_port patch, I hope it's fine now,
Looks good. With Jiri's ack, that'll go into Greg's tree in the next day or
two.
I assumed it
was accepted but it wasn't and I also missed your last comment... I should lose
this bad habit to read only the the visible part of the mail body. :D
Ok, I'll rearrange the code and resend the rfcomm patches.
Ok.
A subtlety I overlooked regarding the .carrier_raised() method is
CLOCAL must _not_ be set in the driver's init_termios. This initialization is
done in rfcomm_init_ttys().
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
