On Tue, Jul 16, 2013 at 04:48:22PM -0400, Peter Hurley wrote:
> >+static int rfcomm_dev_activate(struct tty_port *port, struct tty_struct *tty)
> >+{
> >+ DECLARE_WAITQUEUE(wait, current);
> >+ struct rfcomm_dev *dev = container_of(port, struct rfcomm_dev, port);
> >+ struct rfcomm_dlc *dlc = dev->dlc;
> >+ int err;
> >+
> >+ err = rfcomm_dlc_open(dlc, &dev->src, &dev->dst, dev->channel);
> >+ if (err < 0)
> >+ goto error_no_dlc;
> >+
> >+ /* Wait for DLC to connect */
> >+ add_wait_queue(&dev->wait, &wait);
> >+ while (1) {
> >+ set_current_state(TASK_INTERRUPTIBLE);
> >+
>
>
> >+ if (dlc->state == BT_CLOSED) {
> >+ err = -dev->err;
> >+ break;
> >+ }
> >+
> >+ if (dlc->state == BT_CONNECTED)
> >+ break;
>
> Please consider moving these dlc->state tests into a
> .carrier_raised() port method (this is what the gsm
> driver does). Then this wait loop could go away.
>
I have a question about this: how do I signal an error condition with
carrier_raised? In case of success I should also call some device_move,
rfcomm_tty_copy_pending and rfcomm_dlc_unthrottle. Could I do it in
carrier_raised directly?
Thanks,
Gianluca
> >+ goto error_no_connection;
> >+
> >+ device_move(dev->tty_dev, rfcomm_get_device(dev),
> >+ DPM_ORDER_DEV_AFTER_PARENT);
> >+
> >+ rfcomm_tty_copy_pending(dev);
> >+ rfcomm_dlc_unthrottle(dlc);
> >+ return 0;
> >+
> >+error_no_connection:
> >+ rfcomm_dlc_close(dlc, err);
> >+error_no_dlc:
> >+ return err;
> >+}
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
