Re: [PATCH v2] Fix refcounting issues in rfcomm/tty.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/12/2013 06:18 AM, Gustavo Padovan wrote:
Hi Gianluca,

* Gianluca Anzolin <gianluca@xxxxxxxxxxxxxx> [2013-07-11 21:01:50 +0200]:

Hello,

This is a second version of the previous patches I sent to linux-bluetooth
list. I grouped the two patches together since they are related.

I fixed some bugs in my previous attempt:

If you are fixing different bugs I want one patch for each fix.

1. skb_queue_purge is now called in the cleanup method to avoid a circular
dependency between the dev struct and dlc struct.

2. refcomm_dev_release should check REFCOMM_TTY_RELEASED instead of
REFCOMM_RELEASE_ONHUP.

I checked with both bluez4 and bluez5 and everything works as expected.

Please send a proper inline patch with git-format-patch and git-send-email. Also
get rid of all BT_DBG changes you've made, read the dynamic debug doc to learn
how to print the function name when debugging. And if you are moving functions around
please do this in a separated patch.

Please cc me on this series when these changes are split up and
I'll be happy to review it.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux