Hi Martin, On Mon, Jul 08, 2013, martin.xu@xxxxxxxxxxxxxxx wrote: > From: Martin <martin.xu@xxxxxxxxxxxxxxx> Please fix your git settings to include your full name here (i.e. "Martin Xu"). > @@ -1998,7 +2008,7 @@ static void ext_set_defaults(struct ext_profile *ext) > > ext->mode = BT_IO_MODE_BASIC; > ext->sec_level = BT_IO_SEC_MEDIUM; > - ext->authorize = true; > + ext->authorize = false; > ext->enable_client = true; > ext->enable_server = true; > ext->remote_uuid = NULL; The patch is ok except for the above change. The above change will cause a break in the external D-Bus API behavior where previously you didn't need to explicitly say RequireAuthorization=true to get authorization. With your patch such applications would loose their authorization requirement. Instead, ext->authorize should still default to true. > @@ -2029,6 +2039,9 @@ static void ext_set_defaults(struct ext_profile *ext) > if (settings->mode) > ext->mode = settings->mode; > > + if (settings->authorize) > + ext->authorize = true; > + Once you make the previous fix you'll need to drop the if-statement and unconditionally do "ext->authorize = settings->authorize". Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
