Re: [PATCH v8 5/8] Bluetooth: Use voice setting in defered SCO connection request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marcel,

Le 08/07/2013 21:12, Marcel Holtmann a écrit :
Hi Fred,

+				__constant_cpu_to_le16(SCO_AIRMODE_TRANSP);
why do we hardcode here …

+			cp.retrans_effort = 0x02;
+			break;
+		case SCO_AIRMODE_CVSD:
+			cp.max_latency    = __constant_cpu_to_le16(0xffff);
+			cp.content_format = cpu_to_le16(setting);

… and use setting here.


SCO_AIRMODE_CVSD needs some additional bits describing Input coding and Data format. There is no additional bits for SCO_AIRMODE_TRANSP.

But having it common will fix this ugly line break :)

Fred

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux