Re: [PATCH v8 8/8] Bluetooth: Prevent transparent SCO on older devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinicius,

Le 08/07/2013 04:33, Vinicius Costa Gomes a écrit :
I remember seeing a couple of 2.0 controllers that have Transparent SCO
feature bit set but don't have support for eSCO.

I wonder if it would be better to use Setup Synchronous Connection if
transparent SCO is needed (and the controller supports it).

I saw your previous mail about this. There are several other places in
the code (hci_sco_setup, hci_conn_request_evt maybe others) where Bluez
decides whether to use Add_Sco or Setup_Synchronous_Connection based on
lmp_esco_capable() macro. Supporting transparent data on these adapters would need these places changed as well.

Another problem is in the accepting side, we are using Add SCO if the
controller doesn't support eSCO, this fails (IIRC Invalid LMP Parameters
or somehing) if the other side has requested a SCO link expecting
transparent SCO data.

This patch only applies to connecting side. Accepting side should
not be impacted. If voice settings on both side are matching, I don't
see why it would fail.

Regards,
Fred

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux