> -----Original Message----- > From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth- > owner@xxxxxxxxxxxxxxx] On Behalf Of Luiz Augusto von Dentz > Sent: Friday, July 05, 2013 18:04 > To: martin.xu@xxxxxxxxxxxxxxx > Cc: linux-bluetooth@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] obexd/client: Add client session properties > > Hi Martin, > > On Fri, Jul 5, 2013 at 12:38 PM, <martin.xu@xxxxxxxxxxxxxxx> wrote: > > From: Martin <martin.xu@xxxxxxxxxxxxxxx> > > Please add a description why are the changes necessary. > > > --- > > obexd/client/session.c | 38 ++++++++++++++++++++++++++++++++------ > > 1 file changed, 32 insertions(+), 6 deletions(-) > > > > diff --git a/obexd/client/session.c b/obexd/client/session.c index > > 8d32ed0..e9cbf00 100644 > > --- a/obexd/client/session.c > > +++ b/obexd/client/session.c > > @@ -630,9 +630,6 @@ static gboolean get_source(const > > GDBusPropertyTable *property, { > > struct obc_session *session = data; > > > > - if (session->source == NULL) > > - return FALSE; > > I guess you haven't read carefully may comments from the last time, did > you? This should not be necessary here, otherwise create another patch. Looks like I lost your last mail, could you repeat that. For others comments, I will resend the patch. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html