Re: [PATCH BlueZ v3 1/5] build-sys: Don't build gdbus several times

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lucas,

>>> We are currently compiling gdbus 3 times: one for tests, one for
>>> bluetoothd and another for obexd.
>> 
>> we recompile because of the different CFLAGS for these binaries.
> 
> But they shouldn´t be affecting gdbus.
> 
>> 
>>> $ ls gdbus/*watch.o
>>> gdbus/bluetoothd-watch.o  gdbus/obexd-watch.o  gdbus/watch.o
>>> 
>>> Instead of prepending $(gdbus_sources) to several _SOURCES variable, use
>>> a convenience library.
>> 
>> When we switched to non-recursive build, we stopped building interim libraries. What is the benefit of going back to building them. I am personally fine with building gdbus several times.
> 
> It´s more that there´s no advantage doing otherwise. The small benefit
> is building less files and letting it simpler.

then at least get into a bit of a standard habit. We are building libbluetooth into a public and private version.

Currently we name it libbluetooth-private, but maybe following the systemd "standard", we should start calling that libbluetooth-internal. And then libgdbus-internal.

You also do realize that I will make you do this for all other projects using gdbus.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux