Hi Luiz, > We should notify only the setting that has changed not all of them. > --- > profiles/audio/media.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/profiles/audio/media.c b/profiles/audio/media.c > index eb5ea81..69139a7 100644 > --- a/profiles/audio/media.c > +++ b/profiles/audio/media.c > @@ -1480,7 +1480,7 @@ static gboolean set_property(struct media_player *mp, const char *key, > > g_hash_table_replace(mp->settings, g_strdup(key), g_strdup(value)); > > - settings = list_settings(mp); > + settings = g_list_prepend(NULL, (char *) key); this is dangerous. Can you guarantee that the memory it points to is not used outside of this function. Seriously, making a comment here if this is safe is a good idea. If it is not safe, then it needs to be fixed. We are using const function arguments for pointers to clearly indicate that the lifetime of that pointer is really only guaranteed inside the function. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
