Re: [PATCH v2 0/6] MAP client: Read MASInstanceID for the current connection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

On Fri, Apr 12, 2013 at 12:29 PM, Christian Fetzer
<christian.fetzer@xxxxxxxxxxxxxxxx> wrote:
> From: Christian Fetzer <christian.fetzer@xxxxxxxxxxxx>
>
> Changelog v2:
> - Replaced get_service_record by get_attribute
> - Removed force sdp lookup
>
> --
>
> This patch set allows the MAP client profile implementation to read the
> instance id of the MAS server it is connected to.
>
> This is a prerequisite for receiving event reports and distributing them to the
> correct MAS client instance. The instance id is only available as SDP
> attribute.
>
> Due to the current transport layer abstraction in obexd, the MAP client has no
> direct access to SDP. Therefore I have extended obc_transport to allow concrete
> transports (like Bluetooth) to specify a getattribute function and made
> it available through obc_session_get_attribute. This way, transports can
> provide additional service information to the client implementations.
>
> Christian Fetzer (6):
>   obexd: Cache SDP record in bluetooth transport
>   obexd: Add getattribute to obc_transport
>   obexd: Add bluetooth_getattribute to Bluetooth transport
>   obexd: Add obc_session_get_attribute to session
>   lib: Add attributes MASInstanceID and SupportedMessageTypes
>   obexd: Read service attributes when instantiating MAP session
>
>  lib/sdp.h                |  2 ++
>  obexd/client/bluetooth.c | 36 ++++++++++++++++++++++++++++++++++--
>  obexd/client/map.c       | 31 +++++++++++++++++++++++++++++--
>  obexd/client/session.c   | 11 +++++++++++
>  obexd/client/session.h   |  3 +++
>  obexd/client/transport.h |  1 +
>  6 files changed, 80 insertions(+), 4 deletions(-)
>
> --
> 1.8.2.1

Applied, thanks.

Note that I did some modification to bluetooth_getattribute to check
sdp_record pointer against NULL to be consistent with the rest of the
code and obc_session_get_attribute I simplified it a little bit to be
more readable. Together with this set I pushed some changes to sdptool
so it can now parse MASInstanceID and SupportedMessageTypes.

--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux