>> +uint32_t btd_device_get_class(struct btd_device *device) >> +{ >> + return device->class; >> +} > why not export functions for getting the major and minor class. That seems to better then making a plugin decode that by themselves. Especially since we know they will get it work. Basically we had the device class exported like that in the previous plugin. I don't see a huge advantage on splitting the class in this file instead of in the plugin... and a plugin could also compare with both the major and minor class at the same time. Anyway, is an easy change and I don't have a strong preference. -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html