Hi Gustavo On Sat, Apr 6, 2013 at 4:48 AM, Gustavo Padovan <gustavo@xxxxxxxxxxx> wrote: > Hi David, > > * David Herrmann <dh.herrmann@xxxxxxxxx> [2013-04-05 14:57:35 +0200]: > >> We use _get() and _put() for device ref-counting in the kernel. However, >> hci_conn_put() is _not_ used for ref-counting, hence, rename it to >> hci_conn_drop() so we can later fix ref-counting and introduce >> hci_conn_put(). >> >> hci_conn_hold() and hci_conn_put() are currently used to manage how long a >> connection should be held alive. When the last user drops the connection, >> we spawn a delayed work that performs the disconnect. Obviously, this has >> nothing to do with ref-counting for the _object_ but rather for the >> keep-alive of the connection. >> >> But we really _need_ proper ref-counting for the _object_ to allow >> connection-users like rfcomm-tty, HIDP or others. >> >> Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx> >> --- >> include/net/bluetooth/hci_core.h | 2 +- >> net/bluetooth/hci_conn.c | 6 +++--- >> net/bluetooth/hci_event.c | 36 ++++++++++++++++++------------------ >> net/bluetooth/l2cap_core.c | 6 +++--- >> net/bluetooth/mgmt.c | 6 +++--- >> net/bluetooth/sco.c | 6 +++--- >> net/bluetooth/smp.c | 2 +- >> 7 files changed, 32 insertions(+), 32 deletions(-) > > This patch doesn't apply anymore. Maybe you didn't rebase it on the latest > bluetooth-next before send it. Please do this and resend. You can already add > Marcel's acks to your patches when you resend it. Sorry, I rebased in v1, but it seems there were some changes in between. I rebased again and added Marcel's Acked-By. Thanks! David -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
