Re: [PATCH v2 0/3] Fix Inquiry command support in HCI request framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andre,

On Wed, Mar 27, 2013, Andre Guedes wrote:
> This v2 implements the following comments about the previous patch set:
>  - Consider commands (which don't send Command Complete Event) as completed
>    based on Command Status Event.
>  - Remove hci_req_cmd_status function.
> 
> Thus, for those HCI commands which don't send Command Complete Event, the HCI
> request framework considers they have completed when the Command Status Event
> is received. 
> 
> Regards,
> 
> Andre
> 
> Andre Guedes (3):
>   Bluetooth: Fix HCI request framework
>   Bluetooth: Fix hci_inquiry
>   Bluetooth: Remove hci_req_cmd_status
> 
>  include/net/bluetooth/hci_core.h |  1 -
>  net/bluetooth/hci_core.c         | 39 +++++++++++++--------------------------
>  net/bluetooth/hci_event.c        | 11 ++++++-----
>  3 files changed, 19 insertions(+), 32 deletions(-)

I did a bit of testing and these patches seem to work fine. I'm not
really familiar with the smp_mb__after_clear_bit() usage, but I'll
assume you did your homework to ensure it's correct. Other than that the
patches seem fine to me.

Acked-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux