Re: [RFC 1/2] Bluetooth: Introduce MGMT_EV_DEVICE_NAME_UPDATE event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jaganath,

> A new event is added in mgmt for remote device name updation.
> This event will be sent to userspace whenever a remote name
> event comes and mgmt_connected is already sent.

for me it is pretty much unclear what this event is suppose to do. I am pretty much against sending out random events to just push data into userspace. This sounds more like the case where we should delay the connection setup and notification until the remote name request finished.

Every time you add a new event, the state machine in userspace becomes more and more complicated. And that is one piece we are trying to avoid. The more complicated userspace becomes, the more state mirroring we have to do and then we are back at the level of race conditions that we had with BlueZ 4.x and direct HCI usage. That is something we do not want.

And the general procedure is to have a patch that updates the mgmt API documentation first. I also made it clear in the past that we are not accepting new mgmt commands and events without having a set of test cases for mgmt-tester for it.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux