Re: [PATCH v6 04/17] sbc: add odd member variable to sbc_encoder_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fred,

> sbc/sbc_primitives.c |    2 ++
> sbc/sbc_primitives.h |    1 +
> 2 files changed, 3 insertions(+)
> 
> diff --git a/sbc/sbc_primitives.c b/sbc/sbc_primitives.c
> index dce0ed2..0b48ddb 100644
> --- a/sbc/sbc_primitives.c
> +++ b/sbc/sbc_primitives.c
> @@ -521,6 +521,8 @@ static int sbc_calc_scalefactors_j(
>  */
> void sbc_init_primitives(struct sbc_encoder_state *state)
> {
> +	state->odd = 1;
> +
> 	/* Default implementation for analyze functions */
> 	state->sbc_analyze_4s = sbc_analyze_4b_4s_simd;
> 	state->sbc_analyze_8s = sbc_analyze_4b_8s_simd;
> diff --git a/sbc/sbc_primitives.h b/sbc/sbc_primitives.h
> index 267c277..ffee339 100644
> --- a/sbc/sbc_primitives.h
> +++ b/sbc/sbc_primitives.h
> @@ -40,6 +40,7 @@ struct sbc_encoder_state {
> 	int position;
> 	/* Number of consecutive blocks handled by the encoder */
> 	int increment;
> +	int odd;

lets start using bool here. We should keep the memory footprint as small as possible.

We could also discuss using uint8_t instead of int in some cases. Or go with unsigned int in some cases.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux