Hi Mikel, On Tue, Mar 19, 2013, Mikel Astiz wrote: > +static gint service_state_cmp(gconstpointer a, gconstpointer b) > +{ > + struct btd_service *service = (gpointer) a; Couldn't you just declare the local variable const to avoid the ugly cast? > + service_state_t state = (service_state_t) GPOINTER_TO_INT(b); I think it'd be cleaner to just have: const service_state_t *state = b; > + if (service_get_state(service) == state) And this would then become: if (service_get_state(service) == *state) Btw, why isn't service_state_t prefixed with btd_? Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html