Re: [PATCH v3 2/6] client: Right prompt management on agent input

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

On 13:55 Tue 19 Mar, Alex Deymo wrote:
> Registering an agent shares the user input interface with the normal console
> command interface. The way it is implemented (using rl_message, rl_save_prompt
> and rl_restore_prompt) conflicts with the rl_printf calls that may appear
> while waiting for user input, loosing the [bluetooth]# prompt.
> This patch fixes this and makes clear if the expected input is a command or an
> agent reply changing the color and text of the prompt.

Seems that there are some minor issues with formatting:

[bluetooth]# pair 40:98:4E:XX:XX:XX
Attempting to pair with 40:98:4E:XX:XX:XX
[CHG] Device 40:98:4E:XX:XX:XX Connected: yes
Request confirmation
[blue1m[agent] Confirm passkey 368383 (yes/no): yes


And I would suggest adding a patch to make bluetoothctl register itself as a
default agent by default. I needed to enable it manually before it could
handle incomming pairing requests.


Cheers,
-- 
Vinicius
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux