Hi Johan,
On Fri, Mar 8, 2013 at 8:34 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi,
>
> On Fri, Mar 08, 2013, Johan Hedberg wrote:
>> On Fri, Mar 08, 2013, Andrei Emeltchenko wrote:
>> > On Fri, Mar 08, 2013 at 09:50:09AM +0200, Johan Hedberg wrote:
>> > > Hi Andre,
>> > >
>> > > On Thu, Mar 07, 2013, Andre Guedes wrote:
>> > > > + if (req->err)
>> > > > + return;
>> > >
>> > > Same thing here with the error check, I think if (err < 0) is more
>> > > consistent.
>> >
>> > Using "if (err)" seems to be OK for kernel and looks shorter.
>>
>> It certainly seems to be more common than in user space, but I wouldn't say
>> it's the most common form:
>>
>> jh@x220:linux{master}$ git grep 'if (err)' net/bluetooth/|wc -l
>> 34
>> jh@x220:linux{master}$ git grep 'if (err < 0)' net/bluetooth/|wc -l
>> 89
>> jh@x220:linux{master}$
>
> Looking elsewhere than net/bluetooth/ in the kernel tree the balance
> seems to be the other way around though, so I wont insist on this.
>
> Andre, if you do the fix to BT_ERR() you can also add my acks to all
> patches in your v3 of this set.
>
> Acked-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
Ok, then I'll add the opcode to BT_ERR(), add yours acks and send the v3.
Regards,
Andre
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
