Hi Andre,
> This patch adds the hci_req_cleanup function which basically frees
> all HCI commands queued on a given request.
>
> This function must be called in case something goes wrong during HCI
> request creation. Otherwise, HCI commands already queued on req->cmd_q
> will cause memory leaks.
>
> Signed-off-by: Andre Guedes <andre.guedes@xxxxxxxxxxxxx>
> ---
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index 3a9cbf2..494f8f5 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -1045,6 +1045,7 @@ struct hci_request {
> };
>
> void hci_req_init(struct hci_request *req, struct hci_dev *hdev);
> +void hci_req_cleanup(struct hci_request *req);
> int hci_req_run(struct hci_request *req, hci_req_complete_t complete);
> int hci_req_add(struct hci_request *req, u16 opcode, u32 plen, void *param);
> void hci_req_cmd_complete(struct hci_dev *hdev, u16 opcode, u8 status);
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index b6d44a2..7635c2e 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -2443,6 +2443,11 @@ void hci_req_init(struct hci_request *req, struct hci_dev *hdev)
> req->hdev = hdev;
> }
>
> +void hci_req_cleanup(struct hci_request *req)
> +{
> + skb_queue_purge(&req->cmd_q);
> +}
> +
> int hci_req_run(struct hci_request *req, hci_req_complete_t complete)
> {
> struct hci_dev *hdev = req->hdev;
since the other one is called hci_req_run, then this should be named hci_req_abort or hci_req_cancel.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
