Re: [PATCH v2 1/3] obexd: Move Message.Get parameter attachment into dictionary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

> This is a preparation for adding additional parameters to Message.Get.
> The parsing of the args dictionary is done in parse_get_options.
> 
> The Attachment parameter has been moved into the args dictionary.
> The parameter is now optional defaulting to true.
> ---
> doc/obex-api.txt   | 11 ++++++--
> obexd/client/map.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++--------
> 2 files changed, 78 insertions(+), 14 deletions(-)
> 
> diff --git a/doc/obex-api.txt b/doc/obex-api.txt
> index 759c4d8..9a78284 100644
> --- a/doc/obex-api.txt
> +++ b/doc/obex-api.txt
> @@ -714,10 +714,10 @@ Message hierarchy
> =================
> 
> Service		org.bluez.obex
> -Interface	org.bluez.obex.Message1
> +Interface	org.bluez.obex.Message2
> Object path	[variable prefix]/{session0,session1,...}/{message0,...}
> 
> -Methods		object, dict Get(string targetfile, boolean attachment)
> +Methods		object, dict Get(string targetfile, dict args)

you can not do this. We need to support both APIs in this case. ALso where is the discussion on this API change and especially why do we need it.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux