Hi Marcel,
On Mon, Mar 04, 2013, Marcel Holtmann wrote:
> > This function is analogous to hci_send_cmd() but instead of directly
> > queuing the command to hdev->cmd_q it adds it to the local queue of the
> > asynchronous HCI request being build (inside struct hci_request).
> >
> > Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> > ---
> > include/net/bluetooth/hci_core.h | 1 +
> > net/bluetooth/hci_core.c | 22 ++++++++++++++++++++++
> > 2 files changed, 23 insertions(+)
> >
> > diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> > index 7191217..1a75d2a 100644
> > --- a/include/net/bluetooth/hci_core.h
> > +++ b/include/net/bluetooth/hci_core.h
> > @@ -1048,6 +1048,7 @@ struct hci_request {
> >
> > void hci_req_init(struct hci_request *req, struct hci_dev *hdev);
> > int hci_req_run(struct hci_request *req, hci_req_complete_t complete);
> > +int hci_req_cmd(struct hci_request *req, u16 opcode, u32 plen, void *param);
>
> this is a nitpick, but maybe hci_req_add or hci_req_append is a better
> name. The combination of req_cmd looks a bit weird to me.
I'll go with hci_req_add. It feels most natural and has the nice added
benefit of behing the same length, meaning I can use sed on all patches
and not worry of having to do reformatting for correct line breaks :)
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
