Re: [PATCH BlueZ 3/3] core: Rename hcid.h to main.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

>>> main seems more logical than hcid which use to be the binary name of
>>> bluetoothd really long time ago.
>>> ---
>>> Makefile.am                   | 2 +-
>>> plugins/gatt-example.c        | 2 +-
>>> plugins/neard.c               | 2 +-
>>> profiles/proximity/main.c     | 2 +-
>>> profiles/proximity/reporter.c | 2 +-
>>> src/adapter.c                 | 2 +-
>>> src/attrib-server.c           | 2 +-
>>> src/device.c                  | 2 +-
>>> src/main.c                    | 2 +-
>>> src/{hcid.h => main.h}        | 0
>>> src/plugin.c                  | 2 +-
>>> src/profile.c                 | 2 +-
>>> src/rfkill.c                  | 2 +-
>>> src/sdpd-server.c             | 2 +-
>>> src/sdpd-service.c            | 2 +-
>>> 15 files changed, 14 insertions(+), 14 deletions(-)
>>> rename src/{hcid.h => main.h} (100%)
>> 
>> NAK. main.h is one single header we are not going to have. I do not want main.c to share anything actually. I want main.c to consume everything else.
> 
> Well what is left, bluetoothd.h? Since this is mainly for config
> options I guess this would be fine or you have a better idea?

within ConnMan and oFono we are using connman.h and ofono.h. Since I am short of coming up with a better name than hcid.h that fits, lets leave it like this.

However one thing that needs clearly to be done is to minimise the usage of this header. For example why is it leaking into profiles and plugins in the first place. So please start cleaning that one up first.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux