Re: [RFC] bloodpressure: Add Blood Pressure API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

You might want to fix those in a separate patch set then. Just because
something is in the source tree doesn't mean that it's worth copying
into new code/documentation.

Will do so.

Couldn't you just return a "NotSupported" error to
EnableIntermediateMeasurement?

Sure, it could. It's rather cosmetic change then big one.

Similarly as in thermometer api.

I suspect there are several messed up LE APIs and implementations in the
source tree, so I'd say it's highly advisable to not just blindly copy
from the existing code but also use some common sense and be critical of
what you see.

I wouldn't say this particular api is messed up. For me it looks sane. It's rather the matter of approach than blind copy/paste.

If something existing make sense and is pretty rational then should be used. You can always code one thing in many ways which differ only in details.

Proposed 'NotSupported" seems fine as well. I can go for it and remove BloodPressure1 interface totally.

Any more comments before I will send v2 ?

Thanks,
/Waldek





--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux