Re: [PATCH 01/16] Bluetooth: discard bt_sock_unregister() errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

* David Herrmann <dh.herrmann@xxxxxxxxx> [2013-02-24 19:36:51 +0100]:

> After we successfully registered a socket via bt_sock_register() there is
> no reason to ever check the return code of bt_sock_unregister(). If
> bt_sock_unregister() fails, it means the socket _is_ already unregistered
> so we have what we want, don't we?
> 
> Also, to get bt_sock_unregister() to fail, another part of the kernel has
> to unregister _our_ socket. This is sooo _wrong_ that it will break way
> earlier than when we unregister our socket.
> 
> Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx>
> ---
>  net/bluetooth/bnep/sock.c   | 4 +---
>  net/bluetooth/cmtp/sock.c   | 4 +---
>  net/bluetooth/hci_sock.c    | 4 +---
>  net/bluetooth/hidp/sock.c   | 4 +---
>  net/bluetooth/l2cap_sock.c  | 4 +---
>  net/bluetooth/rfcomm/sock.c | 3 +--
>  net/bluetooth/sco.c         | 3 +--
>  7 files changed, 7 insertions(+), 19 deletions(-)

Patch has been applied to bluetooth-next. Thanks.

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux