Re: [PATCH 10/16] Bluetooth: Remove socket lock from state_change() in l2cap_core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

> This simplifies a lot the state change handling inside l2cap_core.c,
> we got rid of __l2cap_state_change() and l2cap_state_change() doesn't lock
> the socket anymore, instead the socket is locked inside the ops user code
> in l2cap_sock.c.
> 
> In some places we were not using the locked version, and now we are using
> it. There is no side effect in locking the socket in these places.
> 
> Handle the operation of lock the socket to ops user benefit A2MP, since
> there is no socket lock there it doesn't need any special function in
> l2cap work without touching socket locks.

I am lost now. You are changing locking around from a to b to c. A
function previously using locking is now no longer using it. This is
confusing. Why are we doing this again.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux