Hi Lizardo, On Fri, Feb 15, 2013, Anderson Lizardo wrote: > Change since v2: > * Fix commit author mangled during import from GMANE > > Changes since v1: > * Fix license header to match BlueZ license (GPL v2 or later) > * Rename test source file and SDP tests to account for future addition of other > libbluetooth tests > > This series adds various missing DTD validations, specially for SEQ* types. The > lack of these validations allows for a remote device to crash BlueZ due to > invalid memory access. > > I also added unit tests for all affected functions. They are in a separate C > file (unit/test-lib.c), which will in future contain tests for other > libbluetooth API functions. > > The only pending related fixes from my part are some missing NULL pointer > checks when accessing empty sequences. These will take some time to fix as they > affect profile code as well. > > Best Regards, > > Anderson Lizardo (13): > unit: Add initial SDP library unit tests > lib: Add SDP_IS_ALT() macro > lib: Reuse identical code in sdp_get_{add,}_access_protos() > lib: Cleanup coding style in sdp_get_proto_descs() > lib: Fix missing DTD validation while accessing SDP data elements > unit: Add tests for sdp_get_lang_attr() > lib: Add missing DTD validation in sdp_record_print() > lib: Validate DTDs when parsing LanguageBaseAttributeIDList > lib: Validate DTDs when parsing BluetoothProfileDescriptorList > lib: Add comment to BluetoothProfileDescriptorList parsing workaround > lib: Validate DTDs when parsing VersionNumberList > unit: Add tests for sdp_get_profile_descs() > unit: Add tests for sdp_get_server_ver() > > .gitignore | 1 + > Makefile.am | 5 + > lib/sdp.c | 164 +++++++++++++------ > lib/sdp.h | 1 + > unit/test-lib.c | 471 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 596 insertions(+), 46 deletions(-) > create mode 100644 unit/test-lib.c All patches in this set have been applied. Thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html