Hi Antonio, On Sun, Feb 3, 2013 at 1:51 PM, Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote: > The logic is equivalent to the previous one, as device_set_trusted() > returns without doing anything when (device->trusted == trusted), and > the previous implementation was already calling > g_dbus_pending_property_success() just before returning in any exit > path. Or was it meant to be g_dbus_pending_property_error() in the > first exit path? I don't know about that. My mistake. I incorrectly read the diff. And I think the _success() function is correct as it is. > > The previous set_trust() code didn't consider the !device case so we > should be OK if this function assumes the device is always defined. > > If the code is OK I can improve the commit message, yes. Having more text on the commit message is always better than less text :). But in this case, the commit is quite simple, so it is up to you/Johan/Marcel. Best Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
